Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 402034: Make sure to retry SetHiddenPropertiesObject if it (Closed)

Created:
11 years, 1 month ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
iposva, fschneider, yurys
CC:
v8-dev
Visibility:
Public.

Description

Make sure to retry SetHiddenPropertiesObject if it returns a failure. Committed: http://code.google.com/p/v8/source/detail?r=3323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Kasper Lund
11 years, 1 month ago (2009-11-18 00:01:50 UTC) #1
Kasper Lund
This fixes a crash in test_shell_tests introduced in r3294.
11 years, 1 month ago (2009-11-18 00:04:13 UTC) #2
fschneider
LGTM.
11 years, 1 month ago (2009-11-18 00:08:25 UTC) #3
iposva
LGTM! -Ivan
11 years, 1 month ago (2009-11-18 00:37:05 UTC) #4
yurys
11 years, 1 month ago (2009-11-18 08:12:59 UTC) #5
LGTM!

Powered by Google App Engine
This is Rietveld 408576698