Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 40195: An assert was being hit because WaitableEvent's dtor was calling CloseHandle ... (Closed)

Created:
11 years, 9 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

An assert was being hit because WaitableEvent's dtor was calling CloseHandle on a handle that we already closed. BUG=8070 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11078

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M base/waitable_event.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M base/waitable_event_win.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/child_process_host.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
11 years, 9 months ago (2009-03-06 00:51:34 UTC) #1
agl
LGTM http://codereview.chromium.org/40195/diff/1/4 File chrome/common/child_process_host.cc (right): http://codereview.chromium.org/40195/diff/1/4#newcode61 Line 61: process_event_.release(); Capital R on release?
11 years, 9 months ago (2009-03-06 00:57:14 UTC) #2
jam
11 years, 9 months ago (2009-03-06 01:09:21 UTC) #3
http://codereview.chromium.org/40195/diff/1/4
File chrome/common/child_process_host.cc (right):

http://codereview.chromium.org/40195/diff/1/4#newcode61
Line 61: process_event_.release();
On 2009/03/06 00:57:14, agl wrote:
> Capital R on release?

oops, that should have been a ->Release so that the WaitableEvent function is
called, not the scoped_ptr's!  Thanks for pointing it out.

Powered by Google App Engine
This is Rietveld 408576698