chrome/common/child_process_host.cc - Issue 40195: An assert was being hit because WaitableEvent's dtor was calling CloseHandle ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/child_process_host.cc

Issue 40195: An assert was being hit because WaitableEvent's dtor was calling CloseHandle ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/child_process_host.cc

===================================================================

--- chrome/common/child_process_host.cc (revision 11070)

+++ chrome/common/child_process_host.cc (working copy)

@@ -55,6 +55,10 @@

if (handle()) {

watcher_.StopWatching();

ProcessWatcher::EnsureProcessTerminated(handle());

+ // Above call took ownership, so don't want WaitableEvent to assert because

+ // the handle isn't valid anymore.

+ process_event_->Release();

}

« no previous file with comments | « base/waitable_event_win.cc ('k') | no next file » | no next file with comments »