Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 401022: Fix parsing bug in SplitUrlRevision. (Closed)

Created:
11 years, 1 month ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel, djmm
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix parsing bug in SplitUrlRevision. ssh://example.com/git/test.git was not parsed correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M gclient_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/gclient_utils_test.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
11 years, 1 month ago (2009-11-18 04:16:15 UTC) #1
M-A Ruel
11 years, 1 month ago (2009-11-18 17:02:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698