Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: tests/gclient_utils_test.py

Issue 401022: Fix parsing bug in SplitUrlRevision. (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient_utils.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_utils_test.py
diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py
index 6c9a107d95d146a4c63cbc417b65496afc7f2f27..d1150346bdf0390fa59bbc000b0c49af9302fe2b 100644
--- a/tests/gclient_utils_test.py
+++ b/tests/gclient_utils_test.py
@@ -63,6 +63,13 @@ class SplitUrlRevisionTestCase(SuperMoxTestBase):
out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))
self.assertEquals(out_rev, rev)
self.assertEquals(out_url, url)
+ url = "ssh://example.com/git/test.git"
+ out_url, out_rev = gclient_utils.SplitUrlRevision(url)
+ self.assertEquals(out_rev, None)
+ self.assertEquals(out_url, url)
+ out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))
+ self.assertEquals(out_rev, rev)
+ self.assertEquals(out_url, url)
def testSVNUrl(self):
url = "svn://example.com/test"
« no previous file with comments | « gclient_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698