Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 4007004: Revert 63397 - Add a message pump for touchui=1... (Closed)

Created:
10 years, 2 months ago by rjkroege
Modified:
9 years, 5 months ago
Reviewers:
rjkroege1
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 63397 - Add a message pump for touchui=1 The message pump reads events directly from X. For most events, it passes them on to GDK for normal processing. It consumes some events (e.g. keypress events) to demonstrate how it's intended to work. This, of course, makes chrome mostly unusable since you can only use the mouse to do things. But this is a small first step towards capturing events through MPX (e.g. touch etc.) and processing them as chrome pleases. glib message pump: Slightly change architecture This changeset breaks down the glib message pump a little so that it can be easily subclassed. The next set of commits will introduce a subclass that still uses GTK and GDK widgets, but reads events directly from X instead of through GTK/GDK. Review URL: http://codereview.chromium.org/3748002 Patch from Sadrul Chowdhury <sadrul@chromium.org>;. TBR=rjkroege@google.com Probably a dynamic link problem with -lX11. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -205 lines) Patch
M base/base.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M base/message_loop.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M base/message_pump_glib.h View 2 chunks +0 lines, -9 lines 0 comments Download
M base/message_pump_glib.cc View 3 chunks +12 lines, -18 lines 0 comments Download
D base/message_pump_glib_x.h View 1 chunk +0 lines, -63 lines 0 comments Download
D base/message_pump_glib_x.cc View 1 chunk +0 lines, -104 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rjkroege
10 years, 2 months ago (2010-10-21 20:30:19 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698