Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3971004: Revert "Revert "Const-ify RefCountedThreadSafe::AddRef and Release."" (Closed)

Created:
10 years, 2 months ago by Matt Perry
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Raghu Simha, amit, brettw-cc_chromium.org, jam, ncarter (slow), idana, darin-cc_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Revert "Revert "Const-ify RefCountedThreadSafe::AddRef and Release."" chrome_frame failed to compile last time. I needed to add a "mutable" to a member variable in chrome_frame/metrics_service.cc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -54 lines) Patch
M base/message_loop.h View 2 chunks +3 lines, -2 lines 0 comments Download
M base/message_loop_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop_proxy_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/message_loop_proxy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop_proxy_impl_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M base/ref_counted.h View 2 chunks +5 lines, -5 lines 0 comments Download
M base/task.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_thread.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_thread_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chrome_plugin_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper_file_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper_file_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/url_fetcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/url_request_context_getter.h View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/net/url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/net/service_url_request_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/metrics_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
10 years, 2 months ago (2010-10-22 21:38:01 UTC) #1
willchan no longer on Chromium
10 years, 2 months ago (2010-10-22 22:08:40 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698