Revert "Revert "Const-ify RefCountedThreadSafe::AddRef and Release.""

chrome/browser/browser_thread_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
 #include "base/scoped_ptr.h"
 #include "chrome/browser/browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 class BrowserThreadTest : public testing::Test {
  public:
-  void Release() {
+  void Release() const {
     CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
     loop_.PostTask(FROM_HERE, new MessageLoop::QuitTask);
   }
 
  protected:
   virtual void SetUp() {
     ui_thread_.reset(new BrowserThread(BrowserThread::UI));
     file_thread_.reset(new BrowserThread(BrowserThread::FILE));
     ui_thread_->Start();
     file_thread_->Start();
@@ skipping 45 matching lines @@
             NeverDeleted, BrowserThread::DeleteOnWebKitThread> {
    public:
     ~NeverDeleted() {
       CHECK(false);
     }
   };
 
  private:
   scoped_ptr<BrowserThread> ui_thread_;
   scoped_ptr<BrowserThread> file_thread_;
-  MessageLoop loop_;
+  // It's kind of ugly to make this mutable - solely so we can post the Quit
+  // Task from Release(). This should be fixed.
+  mutable MessageLoop loop_;
 };
 
 TEST_F(BrowserThreadTest, PostTask) {
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       NewRunnableFunction(&BasicFunction, MessageLoop::current()));
   MessageLoop::current()->Run();
 }
 
 TEST_F(BrowserThreadTest, Release) {
@@ skipping 64 matching lines @@
     io_thread->Start();
   }
   bool deleted = false;
   scoped_refptr<base::MessageLoopProxy> message_loop_proxy =
       BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO);
   bool ret = message_loop_proxy->PostTask(FROM_HERE, new DummyTask(&deleted));
   EXPECT_FALSE(ret);
   EXPECT_TRUE(deleted);
 }