Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 397031: Launch processes asynchronously so as not to block the UI thread. For now, re... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: return 0 instead of -1 if zygote couldn't launch renderer Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/child_process_launcher.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_browsertest.cc
===================================================================
--- chrome/browser/extensions/extension_browsertest.cc (revision 32255)
+++ chrome/browser/extensions/extension_browsertest.cc (working copy)
@@ -116,15 +116,10 @@
}
void ExtensionBrowserTest::ReloadExtension(const std::string& extension_id) {
- NotificationRegistrar registrar;
- registrar.Add(this, NotificationType::EXTENSION_LOADED,
- NotificationService::AllSources());
-
ExtensionsService* service = browser()->profile()->GetExtensionsService();
service->ReloadExtension(extension_id);
- MessageLoop::current()->PostDelayedTask(
- FROM_HERE, new MessageLoop::QuitTask, kTimeoutMs);
- ui_test_utils::RunMessageLoop();
+ ui_test_utils::RegisterAndWait(NotificationType::EXTENSION_PROCESS_CREATED,
+ this, kTimeoutMs);
}
void ExtensionBrowserTest::UnloadExtension(const std::string& extension_id) {
@@ -259,6 +254,11 @@
MessageLoopForUI::current()->Quit();
break;
+ case NotificationType::EXTENSION_PROCESS_CREATED:
+ std::cout << "Got EXTENSION_PROCESS_CREATED notification.\n";
+ MessageLoopForUI::current()->Quit();
+ break;
+
default:
NOTREACHED();
break;
« no previous file with comments | « chrome/browser/child_process_launcher.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698