Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/child_process_launcher.cc

Issue 397031: Launch processes asynchronously so as not to block the UI thread. For now, re... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: return 0 instead of -1 if zygote couldn't launch renderer Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/child_process_launcher.h ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/child_process_launcher.cc
===================================================================
--- chrome/browser/child_process_launcher.cc (revision 32238)
+++ chrome/browser/child_process_launcher.cc (working copy)
@@ -73,7 +73,7 @@
void LaunchInternal(int ipcfd, CommandLine* cmd_line) {
scoped_ptr<CommandLine> cmd_line_deleter(cmd_line);
- base::ProcessHandle handle;
+ base::ProcessHandle handle = base::kNullProcessHandle;
bool zygote = false;
#if defined(OS_WIN)
handle = sandbox::StartProcess(cmd_line);
@@ -119,7 +119,7 @@
// Actually launch the app.
if (!base::LaunchApp(cmd_line->argv(), fds_to_map, false, &handle))
- handle = 0;
+ handle = base::kNullProcessHandle;
}
#endif
« no previous file with comments | « chrome/browser/child_process_launcher.h ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698