Issue 397031: Launch processes asynchronously so as not to block the UI thread. For now, re...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397031: Launch processes asynchronously so as not to block the UI thread. For now, re... (Closed)

Created:
11 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Launch processes asynchronously so as not to block the UI thread. For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203) BUG=6844 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32264

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : return 0 instead of -1 if zygote couldn't launch renderer #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -341 lines)			Patch
M	base/process_util_posix.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
A +	chrome/browser/child_process_launcher.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/child_process_launcher.cc	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	1	3 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.h	View	1	8 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1	22 chunks	+120 lines, -264 lines	0 comments	Download
M	chrome/browser/renderer_host/mock_render_process_host.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/mock_render_process_host.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_process_host.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/visitedlink_event_listener.cc	View	1	1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/browser/visitedlink_master.h	View	1	1 chunk	+1 line, -7 lines	0 comments	Download
M	chrome/browser/visitedlink_master.cc	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/visitedlink_unittest.cc	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/zygote_host_linux.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/zygote_host_linux.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 1 month ago (2009-11-18 02:28:52 UTC) #2

LGTM on the process_util bits, rest carrying over previous lgtm

Expand Messages | Collapse Messages