Issue 397024: Add missing case for shr in IA-32 disassembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397024: Add missing case for shr in IA-32 disassembler (Closed)

Created:
11 years, 1 month ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add missing case for shr in IA-32 disassembler Committed: http://code.google.com/p/v8/source/detail?r=3316

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -19 lines)			Patch
	M	src/ia32/disasm-ia32.cc	View	1	2 chunks	+21 lines, -19 lines	0 comments	Download
	M	test/cctest/test-disasm-ia32.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/397024/diff/1/3 File src/ia32/disasm-ia32.cc (right): http://codereview.chromium.org/397024/diff/1/3#newcode542 Line 542: case edx: mnem = "rcl"; break; Please ...

11 years, 1 month ago (2009-11-17 10:00:29 UTC) #2

Søren Thygesen Gjesse

11 years, 1 month ago (2009-11-17 10:29:35 UTC) #3

http://codereview.chromium.org/397024/diff/1/3
File src/ia32/disasm-ia32.cc (right):

http://codereview.chromium.org/397024/diff/1/3#newcode542
Line 542: case edx: mnem = "rcl"; break;
On 2009/11/17 10:00:29, Lasse Reichstein wrote:
> Please change these irrelevant register names to either number constants or
> specific constants for shift operations,
> e.g., 
>   enum ShiftSubCode { kROL = 0, kROR = 1, kRCL = 2, kRCR = 3, kSHL = 4, KSHR =
> 5, kSAR = 7 }
> 

Done (but why blame me?).

Expand Messages | Collapse Messages