Issue 397014: Revert 31875 to see whether it fixes reliability bot.

Issue 397014: Revert 31875 to see whether it fixes reliability bot. (Closed)

Created:
11 years, 1 month ago by huanr

Modified:
9 years ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert 31875 to see whether it fixes reliability bot. BUG=25677 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32074

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -228 lines)			Patch
M	base/file_util.h	View	3 chunks	+12 lines, -8 lines	0 comments	Download
M	base/file_util.cc	View	2 chunks	+0 lines, -27 lines	0 comments	Download
M	base/file_util_posix.cc	View	2 chunks	+33 lines, -9 lines	0 comments	Download
M	base/file_util_win.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	build/common.gypi	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	chrome/browser/spellcheck_host.h	View	5 chunks	+5 lines, -13 lines	0 comments	Download
M	chrome/browser/spellcheck_host.cc	View	5 chunks	+24 lines, -60 lines	0 comments	Download
M	chrome/chrome.gyp	View	5 chunks	+8 lines, -15 lines	0 comments	Download
M	chrome/common/notification_type.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View	5 chunks	+14 lines, -5 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/renderer/render_thread.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	2 chunks	+6 lines, -14 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.h	View	4 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.cc	View	5 chunks	+6 lines, -8 lines	0 comments	Download
M	ipc/ipc.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	ipc/ipc_platform_file.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I guess this is OK, but the problem is going to persist on Linux.

11 years, 1 month ago (2009-11-16 18:59:05 UTC) #2

huanr

I want to see whether this indeed fixes the reliability bot. If it does not, ...

11 years, 1 month ago (2009-11-16 19:09:20 UTC) #3

lgtm

Expand Messages | Collapse Messages