net/ftp/ftp_ctrl_response_buffer.cc - Issue 3968001: Update code that previously constructed strings from string iterators only to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_ctrl_response_buffer.cc

Issue 3968001: Update code that previously constructed strings from string iterators only to... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ftp/ftp_ctrl_response_buffer.cc

===================================================================

--- net/ftp/ftp_ctrl_response_buffer.cc (revision 63369)

+++ net/ftp/ftp_ctrl_response_buffer.cc (working copy)

@@ -91,7 +91,7 @@

ParsedLine result;

if (line.length() >= 3) {

- if (base::StringToInt(line.substr(0, 3), &result.status_code))

+ if (base::StringToInt(line.begin(), line.begin() + 3, &result.status_code))

result.has_status_code = (100 <= result.status_code &&

result.status_code <= 599);

if (result.has_status_code && line.length() >= 4 && line[3] == ' ') {

« chrome/test/page_cycler/page_cycler_test.cc ('K') | « net/base/x509_certificate_openssl.cc ('k') | net/ftp/ftp_directory_listing_parser_mlsd.cc » ('j') | no next file with comments »