Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: chrome/test/page_cycler/page_cycler_test.cc

Issue 3968001: Update code that previously constructed strings from string iterators only to... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/page_cycler/page_cycler_test.cc
===================================================================
--- chrome/test/page_cycler/page_cycler_test.cc (revision 63369)
+++ chrome/test/page_cycler/page_cycler_test.cc (working copy)
@@ -366,8 +366,9 @@
new_pos = timings.find(',', pos);
if (new_pos == std::string::npos)
new_pos = timings.length();
- time_str = timings.substr(pos, new_pos - pos);
- if (!base::StringToInt(time_str, &time)) {
+ if (!base::StringToInt(timings.begin() + pos,
+ timings.begin() + new_pos,
+ &time)) {
LOG(ERROR) << "Invalid time reported: " << time_str;
return true;
}

Powered by Google App Engine
This is Rietveld 408576698