Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 3967002: Fix args to RunCommand (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
davidjames
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Fix equals in RunCommand's in cbuildbot. Change-Id: If8cdde42a470c3d07cfd41552cf95dea7567688b BUG= TEST=Ran cbuildbot. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=aa46703

Patch Set 1 #

Patch Set 2 : ws #

Total comments: 5

Patch Set 3 : Fix print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M bin/cbuildbot.py View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M bin/cros_au_test_harness.py View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/cros_build_lib.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sosa
10 years, 2 months ago (2010-10-20 23:17:33 UTC) #1
davidjames
Some nits. http://codereview.chromium.org/3967002/diff/2001/3001 File bin/cbuildbot.py (right): http://codereview.chromium.org/3967002/diff/2001/3001#newcode358 bin/cbuildbot.py:358: '--push_options', '--bypass-hooks','-f', 'push'], Is this change right? ...
10 years, 2 months ago (2010-10-20 23:34:38 UTC) #2
sosa
http://codereview.chromium.org/3967002/diff/2001/3001 File bin/cbuildbot.py (right): http://codereview.chromium.org/3967002/diff/2001/3001#newcode358 bin/cbuildbot.py:358: '--push_options', '--bypass-hooks','-f', 'push'], You're right ... that was correct ...
10 years, 2 months ago (2010-10-20 23:37:18 UTC) #3
davidjames
http://codereview.chromium.org/3967002/diff/2001/3003 File lib/cros_build_lib.py (right): http://codereview.chromium.org/3967002/diff/2001/3003#newcode63 lib/cros_build_lib.py:63: Warning('You are using spaces in arg %s' % arg) ...
10 years, 2 months ago (2010-10-20 23:43:13 UTC) #4
sosa
Cleaned up PTAL
10 years, 2 months ago (2010-10-21 00:33:19 UTC) #5
davidjames
10 years, 2 months ago (2010-10-21 01:20:19 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698