lib/cros_build_lib.py - Issue 3967002: Fix args to RunCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/cros_build_lib.py

Issue 3967002: Fix args to RunCommand (Closed) Base URL: http://git.chromium.org/git/crosutils.git

Patch Set: Fix print Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/cros_build_lib.py

diff --git a/lib/cros_build_lib.py b/lib/cros_build_lib.py

index 47c8f96ae659b6b31394da97f78107f0e10ffa9d..509871c6eedbe06ad9b9e160930e4eae4a3f2fa5 100644

--- a/lib/cros_build_lib.py

+++ b/lib/cros_build_lib.py

@@ -54,8 +54,8 @@ def RunCommand(cmd, print_cmd=True, error_ok=False, error_message=None,

# Print out the command before running.

if print_cmd:

- Info('PROGRAM(%s) -> RunCommand: %s in dir %s' %

- (GetCallerName(), ' '.join(cmd), cwd))

+ Info('PROGRAM(%s) -> RunCommand: %r in dir %s' %

+ (GetCallerName(), cmd, cwd))

try:

proc = subprocess.Popen(cmd, cwd=cwd, stdin=stdin,

@@ -65,7 +65,7 @@ def RunCommand(cmd, print_cmd=True, error_ok=False, error_message=None,

return proc.returncode

if not error_ok and proc.returncode:

- raise Exception('Command "%s" failed.\n' % (' '.join(cmd)) +

+ raise Exception('Command "%r" failed.\n' % (cmd) +

(error_message or error or output or ''))

except Exception, e:

if not error_ok:

« no previous file with comments | « bin/cros_au_test_harness.py ('k') | no next file » | no next file with comments »