Issue 395024: Restore invariant (next of first deallocated must point to the head) before c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 395024: Restore invariant (next of first deallocated must point to the head) before c... (Closed)

Created:
11 years, 1 month ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Restore invariant (next of first deallocated must point to the head) before calling into weak callbacks. Otherwise if callback allocates a new handle, it could orphan some global handles (with disastorous consequences if those global handles are cached). Committed: http://code.google.com/p/v8/source/detail?r=3318

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	src/global-handles.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 1 month ago (2009-11-17 09:05:07 UTC) #1

Lgtm!

Maybe we should consider validating the global handle chain after each gc (debug
mode only of course).  We could check that the links in the chain are set up
correctly and that iterating the nodes visits the same number of nodes as have
been allocated, etc.  That should catch issues like this.

Expand Messages | Collapse Messages