Add support for Ubuntu 9.10 to install-build-deps.sh...

Add support for Ubuntu 9.10 to install-build-deps.sh

Note that binutils-2.19 does not compile on Ubuntu 9.10.
binutils-2.20 compiles on Ubuntu 9.10, but does not comple on 8.04.

BUG=none
TEST=Ran install-build-deps.sh on ubuntu 9.10 and 8.04.

[dank, 2009-11-16 17:20:21]

You can probably use grep instead of egrep, but LGTM

[Joel Stanley (old), 2009-11-17 00:29:03]

Why are you building binutils for Ubuntu 9.10?

If it's for gold, what is wrong with the system supplied version?  You could
call 'apt-get install binutils-gold' and be done with it.

[satorux, 2009-11-17 00:51:51]

Thank you for the comment. That's a great idea.
I didn't know that gold is provided by the system. I'll make a change
accordingly.

Satoru

On Tue, Nov 17, 2009 at 9:29 AM, <joel.stan@gmail.com> wrote:

> Why are you building binutils for Ubuntu 9.10?

> If it's for gold, what is wrong with the system supplied version?  You
> could
> call 'apt-get install binutils-gold' and be done with it.


> http://codereview.chromium.org/395017

[also_not_the_right_dank, 2009-11-17 00:52:46]

Well... if you do that, then valgrind won't build.
You'd need to also change tools/valgrind/build-valgrind-for-chromium.sh.

[Joel Stanley (old), 2009-11-17 00:55:10]

On 2009/11/17 00:52:46, also_not_the_right_dank wrote:
> Well... if you do that, then valgrind won't build.
> You'd need to also change tools/valgrind/build-valgrind-for-chromium.sh.

I made the fix to the valgrind build script to work with Ubuntu/Debian systems
that have gold installed a few months back (you reviewed it :D).  See the logic
involving "/usr/bin/ld.single".

[dank, 2009-11-17 03:08:51]

One nit: the text 
       echo "Installing binutils-gold. Back up ld as ld.single"
and
       echo "Building binutils. Back up ld as ld.orig"

is awkward English, it should be 'Backing' rather than 'Back',
and it should end with a period.
Otherwise LGTM.

[satorux1, 2009-11-17 04:14:40]

Thank you for the comment. Fixed the comments.

On Tue, Nov 17, 2009 at 12:08 PM, <dank@chromium.org> wrote:

> One nit: the text
>        echo "Installing binutils-gold. Back up ld as ld.single"
> and
>        echo "Building binutils. Back up ld as ld.orig"

> is awkward English, it should be 'Backing' rather than 'Back',
> and it should end with a period.
> Otherwise LGTM.



> http://codereview.chromium.org/395017

[Yusuke Sato, 2009-11-17 05:20:27]

Landed in r32154.

On 2009/11/17 04:14:40, satorux1 wrote:
> Thank you for the comment. Fixed the comments.
> 
> On Tue, Nov 17, 2009 at 12:08 PM, <mailto:dank@chromium.org> wrote:
> 
> > One nit: the text
> >        echo "Installing binutils-gold. Back up ld as ld.single"
> > and
> >        echo "Building binutils. Back up ld as ld.orig"
> 
> > is awkward English, it should be 'Backing' rather than 'Back',
> > and it should end with a period.
> > Otherwise LGTM.
> 
> 
> 
> > http://codereview.chromium.org/395017
> 
> 
>