Issue 393010: Disable "arguments" implementation. It was too optimistic in its assumptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 393010: Disable "arguments" implementation. It was too optimistic in its assumptions. (Closed)

Created:
11 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Disable "arguments" implementation. It was too optimistic in its assumptions.

Patch Set 1 #

Total comments: 5

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	src/compiler.cc	View		2 chunks	+4 lines, -7 lines	5 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM. http://codereview.chromium.org/393010/diff/1/2 File src/compiler.cc (right): http://codereview.chromium.org/393010/diff/1/2#newcode601 Line 601: Should we also bailout here? if (scope->arguments() ...

11 years, 1 month ago (2009-11-13 12:49:32 UTC) #2

Lasse Reichstein

11 years, 1 month ago (2009-11-13 13:06:12 UTC) #3

http://codereview.chromium.org/393010/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/393010/diff/1/2#newcode601
Line 601: 
We should, yes. Well spotted.

http://codereview.chromium.org/393010/diff/1/2#newcode764
Line 764: }
And removed this. The first location was the correct one.

http://codereview.chromium.org/393010/diff/1/2#newcode805
Line 805: BAILOUT("non-global/non-slot variable reference");
Not currently, AFAIK.
This is what it said before I removed it. 
Will fix.

Expand Messages | Collapse Messages