Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: src/compiler.cc

Issue 393010: Disable "arguments" implementation. It was too optimistic in its assumptions. (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 0f239920544864cba91155c3ba23cd0576c9e869..6b95363368acf1fd46c47287f250ab3e0c6595f1 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -759,6 +759,9 @@ void CodeGenSelector::VisitDebuggerStatement(DebuggerStatement* stmt) {
void CodeGenSelector::VisitFunctionLiteral(FunctionLiteral* expr) {
+ if (expr->scope()->arguments() != NULL) {
+ BAILOUT("FunctionLiteral uses arguments");
+ }
Lasse Reichstein 2009/11/13 13:06:12 And removed this. The first location was the corre
if (!expr->AllowsLazyCompilation()) {
BAILOUT("FunctionLiteral does not allow lazy compilation");
}
@@ -799,13 +802,7 @@ void CodeGenSelector::VisitVariableProxy(VariableProxy* expr) {
BAILOUT("Lookup slot");
}
} else {
- Property* property = rewrite->AsProperty();
- // In the presence of an arguments object, parameter variables
- // are rewritten into property accesses on that object.
- ASSERT_NOT_NULL(property);
- ASSERT_NE(Expression::kUninitialized, context_);
- Visit(property);
- property->set_context(context_);
+ BAILOUT("non-global/non-slot variable reference");
fschneider 2009/11/13 12:49:32 Are there any other cases than argument access her
Lasse Reichstein 2009/11/13 13:06:12 Not currently, AFAIK. This is what it said before
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698