Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/glue/webframe.h

Issue 39163: Make JavaScript alerts reflect the URL of the frame they came from, not the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/chrome_client_impl.cc ('k') | webkit/glue/webview_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webframe.h
===================================================================
--- webkit/glue/webframe.h (revision 10892)
+++ webkit/glue/webframe.h (working copy)
@@ -114,11 +114,11 @@
// lacks a history item. Otherwise, this will always be true.
virtual bool HasCurrentHistoryState() const = 0;
- // Returns the current URL of the frame, or the empty string if there is no
+ // Returns the current URL of the frame, or an empty GURL if there is no
// URL to retrieve (for example, the frame may never have had any content).
virtual GURL GetURL() const = 0;
- // Returns the URL to the favorite icon for the frame. An empty string is
+ // Returns the URL to the favorite icon for the frame. An empty GURL is
// returned if the frame has not finished loading, or the frame's URL
// protocol is not http or https.
virtual GURL GetFavIconURL() const = 0;
« no previous file with comments | « webkit/glue/chrome_client_impl.cc ('k') | webkit/glue/webview_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698