Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: webkit/glue/chrome_client_impl.cc

Issue 39163: Make JavaScript alerts reflect the URL of the frame they came from, not the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | webkit/glue/webframe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/chrome_client_impl.cc
===================================================================
--- webkit/glue/chrome_client_impl.cc (revision 10892)
+++ webkit/glue/chrome_client_impl.cc (working copy)
@@ -289,12 +289,13 @@
return webview_->delegate() != NULL;
}
-bool ChromeClientImpl::runBeforeUnloadConfirmPanel(const WebCore::String& message,
- WebCore::Frame* frame) {
+bool ChromeClientImpl::runBeforeUnloadConfirmPanel(
+ const WebCore::String& message,
+ WebCore::Frame* frame) {
WebViewDelegate* d = webview_->delegate();
if (d) {
std::wstring wstr = webkit_glue::StringToStdWString(message);
- return d->RunBeforeUnloadConfirm(webview_, wstr);
+ return d->RunBeforeUnloadConfirm(WebFrameImpl::FromFrame(frame), wstr);
}
return false;
}
@@ -325,7 +326,7 @@
#endif
std::wstring wstr = webkit_glue::StringToStdWString(message);
- d->RunJavaScriptAlert(webview_, wstr);
+ d->RunJavaScriptAlert(WebFrameImpl::FromFrame(frame), wstr);
}
}
@@ -335,7 +336,7 @@
WebViewDelegate* d = webview_->delegate();
if (d) {
std::wstring wstr = webkit_glue::StringToStdWString(message);
- return d->RunJavaScriptConfirm(webview_, wstr);
+ return d->RunJavaScriptConfirm(WebFrameImpl::FromFrame(frame), wstr);
}
return false;
}
@@ -350,7 +351,7 @@
std::wstring wstr_message = webkit_glue::StringToStdWString(message);
std::wstring wstr_default = webkit_glue::StringToStdWString(defaultValue);
std::wstring wstr_result;
- bool ok = d->RunJavaScriptPrompt(webview_,
+ bool ok = d->RunJavaScriptPrompt(WebFrameImpl::FromFrame(frame),
wstr_message,
wstr_default,
&wstr_result);
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | webkit/glue/webframe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698