gclient: fix another bug where ssh urls weren't parsed correctly

gclient: fix another bug where ssh urls weren't parsed correctly

ssh://test@example.com wasn't being parsed correctly for revinfo.

Fixed by factoring out all code which splits url into a base_url
and revision.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31910

[M-A Ruel, 2009-11-13 15:01:20]

I'd prefer a small unit test but lgtm

http://codereview.chromium.org/391048/diff/1/4
File gclient_utils.py (right):

http://codereview.chromium.org/391048/diff/1/4#newcode28
Line 28: # splits url and returns a two-tuple: url, rev
Use a docstring instead, e.g.
"""Splits url and returns a (url, rev) tuple."""

http://codereview.chromium.org/391048/diff/1/4#newcode30
Line 30: # Make sure ssh://test@example.com/test.git@stable works
Why not a small unit test? :)

[msb, 2009-11-13 16:14:12]

Fixed. PTAL.

On Fri, Nov 13, 2009 at 7:01 AM,  <maruel@chromium.org> wrote:
> I'd prefer a small unit test but lgtm
>
>
> http://codereview.chromium.org/391048/diff/1/4
> File gclient_utils.py (right):
>
> http://codereview.chromium.org/391048/diff/1/4#newcode28
> Line 28: # splits url and returns a two-tuple: url, rev
> Use a docstring instead, e.g.
> """Splits url and returns a (url, rev) tuple."""
>
> http://codereview.chromium.org/391048/diff/1/4#newcode30
> Line 30: # Make sure ssh://test@example.com/test.git@stable works
> Why not a small unit test? :)
>
> http://codereview.chromium.org/391048
>

[M-A Ruel, 2009-11-13 16:17:04]

lgtm