chrome/renderer/webworker_proxy.h - Issue 390017: Added lifecycle management and sharing support for SharedWorkers. SharedWorkers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/webworker_proxy.h

Issue 390017: Added lifecycle management and sharing support for SharedWorkers. SharedWorkers (Closed)

Patch Set: Changed WebWorkerBase not not call a virtual function from the destructor Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/webworker_proxy.h

diff --git a/chrome/renderer/webworker_proxy.h b/chrome/renderer/webworker_proxy.h

index fb2db3edf21b1862f994604c771888fed8ac4276..112b561d2b3d7bac4292ce5dcc9d68c03c5fc32d 100644

--- a/chrome/renderer/webworker_proxy.h

+++ b/chrome/renderer/webworker_proxy.h

@@ -27,6 +27,7 @@ class WebWorkerProxy : public WebKit::WebWorker, private WebWorkerBase {

WebWorkerProxy(WebKit::WebWorkerClient* client,

ChildThread* child_thread,

int render_view_route_id);

+ ~WebWorkerProxy();

// WebWorker implementation.

virtual void startWorkerContext(const WebKit::WebURL& script_url,

@@ -43,8 +44,7 @@ class WebWorkerProxy : public WebKit::WebWorker, private WebWorkerBase {

void OnMessageReceived(const IPC::Message& message);

private:

- virtual void Disconnect();

+ void CancelCreation();

void OnWorkerCreated();

void OnWorkerContextDestroyed();

void OnPostMessage(const string16& message,