chrome/renderer/webworker_base.h - Issue 390017: Added lifecycle management and sharing support for SharedWorkers. SharedWorkers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/webworker_base.h

Issue 390017: Added lifecycle management and sharing support for SharedWorkers. SharedWorkers (Closed)

Patch Set: Changed WebWorkerBase not not call a virtual function from the destructor Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/webworker_base.h

diff --git a/chrome/renderer/webworker_base.h b/chrome/renderer/webworker_base.h

index 06938633b6b3e0ba439140328ad9b2d330319a29..fe5beccafd194368349aca34be9c266c15ebe46d 100644

--- a/chrome/renderer/webworker_base.h

+++ b/chrome/renderer/webworker_base.h

@@ -36,7 +36,7 @@ class WebWorkerBase : public IPC::Channel::Listener {

bool IsStarted();

// Disconnects the worker (stops listening for incoming messages).

- virtual void Disconnect();

+ void Disconnect();

// Sends a message to the worker thread (forwarded via the RenderViewHost).

// If WorkerStarted() has not yet been called, message is queued.