Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 390015: linux: TCMalloc-based C++ heap profiler. (Closed)

Created:
11 years, 1 month ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: TCMalloc-based C++ heap profiler. Requires compiling with linux_use_tcmalloc=1. When enabled by --heap-profiler flag in test_shell exposes chromium.HeapProfiler object to JavaScript. The object has three methods: o start() -- starts profiling o dump() -- dumps data accumulated since start() to file named like chromium-YYYY-MM-DD-TS.heap o stop() -- stops profiling. Output can be analyzed by third_party/tcmalloc/tcmalloc/src/pprof. For example: $ third_party/tcmalloc/tcmalloc/src/pprof \ sconsbuild/Release/test_shell \ chromium-2009-11-06-1234567890.heap See http://code.google.com/p/google-perftools/ for details on how to use pprof. Patch contributed by vitalyr@chromium.org. Original review at http://codereview.chromium.org/377010/show. TBR=vitalyr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -5 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M build/common.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
A webkit/extensions/v8/heap_profiler_extension.h View 1 chunk +23 lines, -0 lines 0 comments Download
A webkit/extensions/v8/heap_profiler_extension.cc View 1 chunk +111 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
willchan no longer on Chromium
11 years, 1 month ago (2009-11-11 19:25:34 UTC) #1
willchan no longer on Chromium
Reviewers: Vitaly, Description: linux: TCMalloc-based C++ heap profiler. Requires compiling with linux_use_tcmalloc=1. When enabled by ...
11 years, 1 month ago (2009-11-11 19:25:53 UTC) #2
Vitaly Repeshko
11 years, 1 month ago (2009-11-11 21:17:51 UTC) #3
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698