Make 'gcl diff emptychange' show nothing if given change, |emptychange|, does...

Make 'gcl diff emptychange' show nothing if given change, |emptychange|, doesn't contain files.

BUG=27243
TEST=Create change which contains no files and confirm 'gcl diff createdchange' doesn't output anything.

M      gcl.py

[M-A Ruel, 2009-11-10 13:53:43]

lgtm

[M-A Ruel, 2009-11-10 13:54:01]

lgtm

http://codereview.chromium.org/388001

[hayato-do-not-use-this-account, 2009-11-10 18:43:03]

Reviewers: Marc-Antoine Ruel,

Description:
Make 'gcl diff emptychange' show nothing if given change, |emptychange|,  
doesn't
contain files.

BUG=27243
TEST=Create change which contains no files and confirm 'gcl diff  
createdchange'
doesn't output anything.

M      gcl.py


Please review this at http://codereview.chromium.org/388001

SVN Base: http://src.chromium.org/svn/trunk/tools/depot_tools/

Affected files:
   M     gcl.py


Index: gcl.py
===================================================================
--- gcl.py	(revision 31548)
+++ gcl.py	(working copy)
@@ -1283,6 +1283,8 @@
    else:
      # Everything else that is passed into gcl we redirect to svn, after  
adding
      # the files. This allows commands such as 'gcl diff xxx' to work.
+    if command == "diff" and not change_info.GetFileNames():
+      return 0
      args =["svn", command]
      root = GetRepositoryRoot()
      args.extend([os.path.join(root, x) for x in  
change_info.GetFileNames()])

[hayato-do-not-use-this-account, 2009-11-11 05:01:55]

Thank you for LGTM.

Could you land it on behalf of me? I don't have a commit access.

On 2009/11/10 13:54:01, Marc-Antoine Ruel wrote:
> lgtm
> 
> http://codereview.chromium.org/388001