Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 387023: Building FFmpeg in tree for arm (Closed)

Created:
11 years, 1 month ago by Alpha Left Google
Modified:
9 years, 6 months ago
Reviewers:
awong
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Building FFmpeg in tree for arm Changes yasm to be built for host instead of target. Also don't need to depend on yasm if build ing for arm. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31929

Patch Set 1 #

Patch Set 2 : ffmpeg gyp #

Patch Set 3 : version #

Total comments: 2

Patch Set 4 : moved dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+905 lines, -34 lines) Patch
M build/all.gyp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 2 3 1 chunk +11 lines, -7 lines 0 comments Download
M third_party/ffmpeg/ffmpeg.gyp View 1 2 3 7 chunks +69 lines, -24 lines 0 comments Download
A third_party/ffmpeg/source/config/Chromium/linux/arm/config.h View 1 chunk +811 lines, -0 lines 0 comments Download
A third_party/ffmpeg/source/config/Chromium/linux/arm/version.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/yasm/yasm.gyp View 10 chunks +10 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alpha Left Google
Will need some simple fix in FFmpeg's code to build after this change.
11 years, 1 month ago (2009-11-11 18:33:44 UTC) #1
Alpha Left Google
Reviewers: awong, Message: Will need some simple fix in FFmpeg's code to build after this ...
11 years, 1 month ago (2009-11-11 18:34:04 UTC) #2
awong
couple of small changes needed. http://codereview.chromium.org/387023/diff/2001/2004 File third_party/ffmpeg/ffmpeg.gyp (right): http://codereview.chromium.org/387023/diff/2001/2004#newcode62 Line 62: 'dependencies': [ Move ...
11 years, 1 month ago (2009-11-12 23:11:00 UTC) #3
Alpha Left Google
On 2009/11/12 23:11:00, awong wrote: > couple of small changes needed. > > http://codereview.chromium.org/387023/diff/2001/2004 > ...
11 years, 1 month ago (2009-11-12 23:49:02 UTC) #4
Alpha Left Google
ping.
11 years, 1 month ago (2009-11-13 19:04:43 UTC) #5
awong
11 years, 1 month ago (2009-11-13 19:08:06 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698