Make 'gcl change --force' generate random changename in read-only checkout....

Make 'gcl change --force' generate random changename in read-only checkout.

BUG=27241
TEST=running 'gcl change --force' in a read-only checkout creates random changename.

M      gcl.py

[M-A Ruel, 2009-11-10 13:53:34]

Ok, this is more a hack than anything else but until this is switched to
OptParser, I guess that's the simplest way to make it work.

lgtm

[M-A Ruel, 2009-11-10 13:53:53]

Ok, this is more a hack than anything else but until this is switched to
OptParser, I guess that's the simplest way to make it work.

lgtm

http://codereview.chromium.org/387001

[hayato-do-not-use-this-account, 2009-11-10 18:42:55]

Reviewers: Marc-Antoine Ruel,

Description:
Make 'gcl change --force' generate random changename in read-only checkout.

BUG=27241
TEST=running 'gcl change --force' in a read-only checkout creates random
changename.

M      gcl.py



Please review this at http://codereview.chromium.org/387001

SVN Base: http://src.chromium.org/svn/trunk/tools/depot_tools/

Affected files:
   M     gcl.py


Index: gcl.py
===================================================================
--- gcl.py	(revision 31548)
+++ gcl.py	(working copy)
@@ -1239,12 +1239,18 @@
      DeleteEmptyChangeLists()
      return 0

-  if len(argv) == 2:
-    if command == "change":
+  if command == "change":
+    if len(argv) == 2:
        # Generate a random changelist name.
        changename = GenerateChangeName()
+    elif argv[2] == '--force':
+      changename = GenerateChangeName()
+      # argv[3:] is passed to Chage() later. Change() should  
receive '--force'.
+      argv.insert(2, changename)
      else:
-      ErrorExit("Need a changelist name.")
+      changename = argv[2]
+  elif len(argv) == 2:
+    ErrorExit("Need a changelist name.")
    else:
      changename = argv[2]

[hayato-do-not-use-this-account, 2009-11-11 04:51:14]

Thank you for LGTM.

Could you land it on behalf of me?
I don't have a commit access.

On 2009/11/10 13:53:53, Marc-Antoine Ruel wrote:
> Ok, this is more a hack than anything else but until this is switched to
> OptParser, I guess that's the simplest way to make it work.
> 
> lgtm
> 
> http://codereview.chromium.org/387001

[M-A Ruel, 2009-11-13 20:34:21]

Sorry I wasn't clear but I checked it in as soon as I lgtm, 3 days ago.