Issue 3856002: autotest: fix race condition between cron crash_sender and test invoked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3856002: autotest: fix race condition between cron crash_sender and test invoked (Closed)

Created:
10 years, 2 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

autotest: fix race condition between cron crash_sender and test invoked Change-Id: I0c77f5b18d37a6086f3e05b0dae4de2ed5be245a BUG=7765 TEST=CrashSender UserCrash Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4f61965

Patch Set 1 #

Patch Set 2 : fix tab #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -19 lines)			Patch
M	client/bin/site_crash_test.py	View	1	4 chunks	+18 lines, -5 lines	0 comments	Download
M	client/site_tests/logging_CrashSender/logging_CrashSender.py	View		11 chunks	+5 lines, -12 lines	0 comments	Download
M	client/site_tests/logging_KernelCrash/logging_KernelCrash.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	client/site_tests/logging_UserCrash/logging_UserCrash.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 2 months ago (2010-10-18 02:23:49 UTC) #2

LGTM

On Sun, Oct 17, 2010 at 2:56 PM,  <kmixter@chromium.org> wrote:
> Reviewers: sosa,
>
> Description:
> bugs
>
> Change-Id: Ibc70e999115e949e201d58a96e9b54c31560ed87
>
> autotest: fix race condition between cron crash_sender and test invoked
>
> Change-Id: I0c77f5b18d37a6086f3e05b0dae4de2ed5be245a
>
> BUG=7765
> TEST=CrashSender UserCrash
>
> Please review this at http://codereview.chromium.org/3856002/show
>
> SVN Base: http://git.chromium.org/git/autotest.git
>
> Affected files:
>  M client/bin/site_crash_test.py
>  M client/site_tests/logging_CrashSender/logging_CrashSender.py
>  M client/site_tests/logging_KernelCrash/logging_KernelCrash.py
>  M client/site_tests/logging_UserCrash/logging_UserCrash.py
>
>
>

Expand Messages | Collapse Messages