client/site_tests/logging_KernelCrash/logging_KernelCrash.py - Issue 3856002: autotest: fix race condition between cron crash_sender and test invoked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/site_tests/logging_KernelCrash/logging_KernelCrash.py

Issue 3856002: autotest: fix race condition between cron crash_sender and test invoked (Closed) Base URL: http://git.chromium.org/git/autotest.git

Patch Set: fix tab Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « client/site_tests/logging_CrashSender/logging_CrashSender.py ('k') | client/site_tests/logging_UserCrash/logging_UserCrash.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: client/site_tests/logging_KernelCrash/logging_KernelCrash.py

diff --git a/client/site_tests/logging_KernelCrash/logging_KernelCrash.py b/client/site_tests/logging_KernelCrash/logging_KernelCrash.py

index c99dd3fb088e46ee040ba52665163215acc69b0d..c0b5f7d5d8f714dd0bd3817a505a46e466488755 100644

--- a/client/site_tests/logging_KernelCrash/logging_KernelCrash.py

+++ b/client/site_tests/logging_KernelCrash/logging_KernelCrash.py

@@ -69,7 +69,6 @@ class logging_KernelCrash(site_crash_test.CrashTest):

kcrash_report = self._get_kcrash_name()

if not os.path.exists(kcrash_report):

raise error.TestFail('Crash report gone')

- self._set_sending(True)

result = self._call_sender_one_crash(

report=os.path.basename(kcrash_report))

if (not result['send_attempt'] or not result['send_success'] or