Issue 3853003: Handle gclient_utils.Error exceptions in trychange.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3853003: Handle gclient_utils.Error exceptions in trychange.py (Closed)

Created:
10 years, 2 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Handle gclient_utils.Error exceptions in trychange.py TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63047

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	trychange.py	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

10 years, 2 months ago (2010-10-19 13:11:01 UTC) #2

lgtm

http://codereview.chromium.org/3853003/diff/1/2
File trychange.py (right):

http://codereview.chromium.org/3853003/diff/1/2#newcode612
trychange.py:612: print "Argument%s \"%s\" not understood" % (plural, "
".join(args[1:]))
shouldn't this go to stderr as well?

Expand Messages | Collapse Messages