Handle gclient_utils.Error exceptions in trychange.py

trychange.py

 #!/usr/bin/python
 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Client-side script to send a try job to the try server. It communicates to
 the try server by either writting to a svn repository or by directly connecting
 to the server by HTTP.
 """
 
 import datetime
@@ skipping 591 matching lines @@
   if len(args) == 2 and args[1] == 'help':
     parser.print_help()
     return 0
 
   # If they've said something confusing, don't spawn a try job until you
   # understand what they want.
   if len(args) > 1:
     plural = ""
     if len(args) > 2:
       plural = "s"
     print "Argument%s \"%s\" not understood" % (plural, " ".join(args[1:]))

[jochen (gone - plz use gerrit), 2010/10/19 13:11:01]

shouldn't this go to stderr as well?

     parser.print_help()
     return 1
 
   LOG_FORMAT = '%(levelname)s %(filename)s(%(lineno)d): %(message)s'
   if not swallow_exception:
     if options.verbose == 0:
       logging.basicConfig(level=logging.WARNING, format=LOG_FORMAT)
     elif options.verbose == 1:
       logging.basicConfig(level=logging.INFO, format=LOG_FORMAT)
     elif options.verbose > 1:
@@ skipping 116 matching lines @@
         return 0
     except NoTryServerAccess:
       if not can_svn:
         raise
     _SendChangeSVN(options)
     PrintSuccess(options)
     return 0
   except (InvalidScript, NoTryServerAccess), e:
     if swallow_exception:
       return 1
-    print e
+    print >> sys.stderr, e
+    return 1
+  except gclient_utils.Error, e:
+    print >> sys.stderr, e
     return 1
   return 0
 
 
 if __name__ == "__main__":
   sys.exit(TryChange(None, [], False))