Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 385136: Step next should respect do/while condition block. (Closed)

Created:
11 years, 1 month ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev, pfeldman
Visibility:
Public.

Description

Step next should respect do/while condition block. Condition block of do/while statements is a valid break location so it should have its own position. The block is represented by a regular Expression node so we cannot store the position in it, instead the position is stored in a separate field in DoWhileStatement AST node. BUG=514 Committed: http://code.google.com/p/v8/source/detail?r=3312

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -1 line) Patch
M src/arm/codegen-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ast.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codegen.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M src/parser.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/debug-stepnext-do-while.js View 1 2 3 4 5 6 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
11 years, 1 month ago (2009-11-16 19:39:20 UTC) #1
Søren Thygesen Gjesse
11 years, 1 month ago (2009-11-16 21:48:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698