More search engine prepopulate data updating.

More search engine prepopulate data updating.

notes:
- did not include startslim as its popularity was too low (as reported by Alexa)
- did not use espanol.yahoo.com for bolivia, instead used yahoo.com (as with most Latin American countries). espanol.yahoo.com seems to be aimed at es_US
- Did not remove fr_CA engines, because it seems prudent to use localized engines when possible
- Switzerland - 14 engines were listed. I took the 6 that I thought were probably most popular.
- did not include Onkosh as its popularity was too low (as reported by Alexa)
- yp.com.hk - this is Yellow Pages Hong Kong, not a web search. Did not include it.
- virgilio - I am super confused as to whether it's virgilio or virgilio.alice.it. Left it alone.
- Did not remove delfi_lt because it is a really popular site (probably popular search engine) in Lithuania. The fact that it is localized is not a mark against it.
- xalo.vn - again not popular enough

List of completely removed engines (i.e. engines no longer in use for _any_ country):
- adonde
- aeiou
- aladin
- altavista_es
- altavista_mx
- aol_fr
- aonde
- ask_de
- ask_uk
- biglobe
- bigmir
- bluewin
- conexcol
- delfi_ee
- embla
- empas
- eniro_dk
- finna
- forthnet
- gigabusca
- goo
- iafrica
- ilse
- jamaicalive
- krstarica
- live*
- lycos*
- matkurja
- meta
- msn*
- mweb
- mywebsearch
- nan10
- netindex
- nifty
- ohperu
- orange
- sesam
- sogou
- soso
- szm
- t_online
- terra_ec
- terra_mx
- terra_pe
- toile
- vinden
- voila
- web_de
- yagua
- yam



BUG=23909
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31686

[Evan Stade, 2009-11-11 03:39:01]

Reviewers: Peter Kasting,

Description:
More search engine prepopulate data updating.

notes:
- did not include startslim as its popularity was too low (as reported by  
Alexa)
- did not use espanol.yahoo.com for bolivia, instead used yahoo.com (as with
most Latin American countries). espanol.yahoo.com seems to be aimed at es_US
- Did not remove fr_CA engines, because it seems prudent to use localized
engines when possible
- Switzerland - 14 engines were listed. I took the 6 that I thought were
probably most popular.
- did not include Onkosh as its popularity was too low (as reported by  
Alexa)
- yp.com.hk - this is Yellow Pages Hong Kong, not a web search. Did not  
include
it.
- virgilio - I am super confused as to whether it's virgilio or
virgilio.alice.it. Left it alone.
- Did not remove delfi_lt because it is a really popular site (probably  
popular
search engine) in Lithuania. The fact that it is localized is not a mark  
against
it.
- xalo.vn - again not popular enough

List of completely removed engines (i.e. engines no longer in use for _any_
country):
- adonde
- aeiou
- aladin
- altavista_es
- altavista_mx
- aol_fr
- aonde
- ask_de
- ask_uk
- biglobe
- bigmir
- bluewin
- conexcol
- delfi_ee
- embla
- empas
- eniro_dk
- finna
- forthnet
- gigabusca
- goo
- iafrica
- ilse
- jamaicalive
- krstarica
- live*
- lycos*
- matkurja
- meta
- msn*
- mweb
- mywebsearch
- nan10
- netindex
- nifty
- ohperu
- orange
- sesam
- sogou
- soso
- szm
- t_online
- terra_ec
- terra_mx
- terra_pe
- toile
- vinden
- voila
- web_de
- yagua
- yam



BUG=23909


Please review this at http://codereview.chromium.org/385032

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/browser/search_engines/template_url_prepopulate_data.cc

[Peter Kasting, 2009-11-11 04:20:45]

LGTM although I suggest adding explicit comments on all the places you use L""
as a keyword saying which engine this is sitting alongside (as the existing code
does)

http://codereview.chromium.org/385032/diff/5/1001
File chrome/browser/search_engines/template_url_prepopulate_data.cc (right):

http://codereview.chromium.org/385032/diff/5/1001#newcode60
Line 60: // The following unique IDs are available:
Nit: I'd just put all these in a big block, like
// 1, 2, 3, 4, ...
...Just to save space

[Peter Kasting, 2009-11-11 04:21:03]

LGTM although I suggest adding explicit comments on all the places you use  
L""
as a keyword saying which engine this is sitting alongside (as the existing  
code
does)


http://codereview.chromium.org/385032/diff/5/1001
File chrome/browser/search_engines/template_url_prepopulate_data.cc
(right):

http://codereview.chromium.org/385032/diff/5/1001#newcode60
Line 60: // The following unique IDs are available:
Nit: I'd just put all these in a big block, like
// 1, 2, 3, 4, ...
...Just to save space

http://codereview.chromium.org/385032

[Peter Kasting, 2009-11-11 04:22:28]

http://codereview.chromium.org/385032/diff/5/1001
File chrome/browser/search_engines/template_url_prepopulate_data.cc (right):

http://codereview.chromium.org/385032/diff/5/1001#newcode1302
Line 1302: L"virgilio.alice.it",
Based on testing, go ahead and change this to virgilio.it.

[Peter Kasting, 2009-11-11 04:22:47]

http://codereview.chromium.org/385032/diff/5/1001
File chrome/browser/search_engines/template_url_prepopulate_data.cc
(right):

http://codereview.chromium.org/385032/diff/5/1001#newcode1302
Line 1302: L"virgilio.alice.it",
Based on testing, go ahead and change this to virgilio.it.

http://codereview.chromium.org/385032

[Evan Stade, 2009-11-11 19:16:09]

On 2009/11/11 04:21:03, Peter Kasting wrote:
> LGTM although I suggest adding explicit comments on all the places you use  
> L""
> as a keyword saying which engine this is sitting alongside (as the existing  
> code
> does)

done.

http://codereview.chromium.org/385032/diff/5/1001
File chrome/browser/search_engines/template_url_prepopulate_data.cc (right):

http://codereview.chromium.org/385032/diff/5/1001#newcode60
Line 60: // The following unique IDs are available:
On 2009/11/11 04:20:45, Peter Kasting wrote:
> Nit: I'd just put all these in a big block, like
> // 1, 2, 3, 4, ...
> ...Just to save space

Done.

http://codereview.chromium.org/385032/diff/5/1001#newcode1302
Line 1302: L"virgilio.alice.it",
On 2009/11/11 04:22:28, Peter Kasting wrote:
> Based on testing, go ahead and change this to virgilio.it.

Done.

http://codereview.chromium.org/385032/diff/5/1001#newcode1302
Line 1302: L"virgilio.alice.it",
On 2009/11/11 04:22:28, Peter Kasting wrote:
> Based on testing, go ahead and change this to virgilio.it.

Done.

[Evan Stade, 2009-11-11 19:16:29]

On 2009/11/11 04:21:03, Peter Kasting wrote:
> LGTM although I suggest adding explicit comments on all the places you use
> L""
> as a keyword saying which engine this is sitting alongside (as the  
> existing
> code
> does)

done.



http://codereview.chromium.org/385032/diff/5/1001
File chrome/browser/search_engines/template_url_prepopulate_data.cc
(right):

http://codereview.chromium.org/385032/diff/5/1001#newcode60
Line 60: // The following unique IDs are available:
On 2009/11/11 04:20:45, Peter Kasting wrote:
> Nit: I'd just put all these in a big block, like
> // 1, 2, 3, 4, ...
> ...Just to save space

Done.

http://codereview.chromium.org/385032/diff/5/1001#newcode1302
Line 1302: L"virgilio.alice.it",
On 2009/11/11 04:22:28, Peter Kasting wrote:
> Based on testing, go ahead and change this to virgilio.it.

Done.

http://codereview.chromium.org/385032/diff/5/1001#newcode1302
Line 1302: L"virgilio.alice.it",
On 2009/11/11 04:22:28, Peter Kasting wrote:
> Based on testing, go ahead and change this to virgilio.it.

Done.

http://codereview.chromium.org/385032