Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: net/socket/socks_client_socket_unittest.cc

Issue 384024: There was confusion in the mock socket classes due to... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/socks5_client_socket_unittest.cc ('k') | net/socket_stream/socket_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socks_client_socket_unittest.cc
===================================================================
--- net/socket/socks_client_socket_unittest.cc (revision 31569)
+++ net/socket/socks_client_socket_unittest.cc (working copy)
@@ -39,7 +39,7 @@
ClientSocket* tcp_sock_;
TestCompletionCallback callback_;
scoped_refptr<MockHostResolver> host_resolver_;
- scoped_ptr<MockSocket> mock_socket_;
+ scoped_ptr<SocketDataProvider> data_;
private:
DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketTest);
@@ -61,8 +61,8 @@
int port) {
TestCompletionCallback callback;
- mock_socket_.reset(new StaticMockSocket(reads, writes));
- tcp_sock_ = new MockTCPClientSocket(address_list_, mock_socket_.get());
+ data_.reset(new StaticSocketDataProvider(reads, writes));
+ tcp_sock_ = new MockTCPClientSocket(address_list_, data_.get());
int rv = tcp_sock_->Connect(&callback, NULL);
EXPECT_EQ(ERR_IO_PENDING, rv);
« no previous file with comments | « net/socket/socks5_client_socket_unittest.cc ('k') | net/socket_stream/socket_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698