Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: net/socket/socks_client_socket_unittest.cc

Issue 384024: There was confusion in the mock socket classes due to... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/socks_client_socket.h" 5 #include "net/socket/socks_client_socket.h"
6 6
7 #include "net/base/address_list.h" 7 #include "net/base/address_list.h"
8 #include "net/base/load_log.h" 8 #include "net/base/load_log.h"
9 #include "net/base/load_log_unittest.h" 9 #include "net/base/load_log_unittest.h"
10 #include "net/base/mock_host_resolver.h" 10 #include "net/base/mock_host_resolver.h"
(...skipping 21 matching lines...) Expand all
32 SOCKSClientSocket* BuildMockSocket(MockRead reads[], MockWrite writes[], 32 SOCKSClientSocket* BuildMockSocket(MockRead reads[], MockWrite writes[],
33 const std::string& hostname, int port); 33 const std::string& hostname, int port);
34 virtual void SetUp(); 34 virtual void SetUp();
35 35
36 protected: 36 protected:
37 scoped_ptr<SOCKSClientSocket> user_sock_; 37 scoped_ptr<SOCKSClientSocket> user_sock_;
38 AddressList address_list_; 38 AddressList address_list_;
39 ClientSocket* tcp_sock_; 39 ClientSocket* tcp_sock_;
40 TestCompletionCallback callback_; 40 TestCompletionCallback callback_;
41 scoped_refptr<MockHostResolver> host_resolver_; 41 scoped_refptr<MockHostResolver> host_resolver_;
42 scoped_ptr<MockSocket> mock_socket_; 42 scoped_ptr<SocketDataProvider> data_;
43 43
44 private: 44 private:
45 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketTest); 45 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketTest);
46 }; 46 };
47 47
48 SOCKSClientSocketTest::SOCKSClientSocketTest() 48 SOCKSClientSocketTest::SOCKSClientSocketTest()
49 : host_resolver_(new MockHostResolver) { 49 : host_resolver_(new MockHostResolver) {
50 } 50 }
51 51
52 // Set up platform before every test case 52 // Set up platform before every test case
53 void SOCKSClientSocketTest::SetUp() { 53 void SOCKSClientSocketTest::SetUp() {
54 PlatformTest::SetUp(); 54 PlatformTest::SetUp();
55 } 55 }
56 56
57 SOCKSClientSocket* SOCKSClientSocketTest::BuildMockSocket( 57 SOCKSClientSocket* SOCKSClientSocketTest::BuildMockSocket(
58 MockRead reads[], 58 MockRead reads[],
59 MockWrite writes[], 59 MockWrite writes[],
60 const std::string& hostname, 60 const std::string& hostname,
61 int port) { 61 int port) {
62 62
63 TestCompletionCallback callback; 63 TestCompletionCallback callback;
64 mock_socket_.reset(new StaticMockSocket(reads, writes)); 64 data_.reset(new StaticSocketDataProvider(reads, writes));
65 tcp_sock_ = new MockTCPClientSocket(address_list_, mock_socket_.get()); 65 tcp_sock_ = new MockTCPClientSocket(address_list_, data_.get());
66 66
67 int rv = tcp_sock_->Connect(&callback, NULL); 67 int rv = tcp_sock_->Connect(&callback, NULL);
68 EXPECT_EQ(ERR_IO_PENDING, rv); 68 EXPECT_EQ(ERR_IO_PENDING, rv);
69 rv = callback.WaitForResult(); 69 rv = callback.WaitForResult();
70 EXPECT_EQ(OK, rv); 70 EXPECT_EQ(OK, rv);
71 EXPECT_TRUE(tcp_sock_->IsConnected()); 71 EXPECT_TRUE(tcp_sock_->IsConnected());
72 72
73 return new SOCKSClientSocket(tcp_sock_, 73 return new SOCKSClientSocket(tcp_sock_,
74 HostResolver::RequestInfo(hostname, port), 74 HostResolver::RequestInfo(hostname, port),
75 host_resolver_); 75 host_resolver_);
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 *log, 0, LoadLog::TYPE_SOCKS_CONNECT, LoadLog::PHASE_BEGIN)); 304 *log, 0, LoadLog::TYPE_SOCKS_CONNECT, LoadLog::PHASE_BEGIN));
305 rv = callback_.WaitForResult(); 305 rv = callback_.WaitForResult();
306 EXPECT_EQ(OK, rv); 306 EXPECT_EQ(OK, rv);
307 EXPECT_TRUE(user_sock_->IsConnected()); 307 EXPECT_TRUE(user_sock_->IsConnected());
308 EXPECT_EQ(SOCKSClientSocket::kSOCKS4a, user_sock_->socks_version_); 308 EXPECT_EQ(SOCKSClientSocket::kSOCKS4a, user_sock_->socks_version_);
309 EXPECT_TRUE(LogContains( 309 EXPECT_TRUE(LogContains(
310 *log, -1, LoadLog::TYPE_SOCKS_CONNECT, LoadLog::PHASE_END)); 310 *log, -1, LoadLog::TYPE_SOCKS_CONNECT, LoadLog::PHASE_END));
311 } 311 }
312 312
313 } // namespace net 313 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/socks5_client_socket_unittest.cc ('k') | net/socket_stream/socket_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698