Chromium Code Reviews

Issue 3836005: Move pe_image and registry from base to base/win and use the namespace. It re... (Closed)

Created:
10 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, ben+cc_chromium.org, amit, brettw-cc_chromium.org, jam, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org, James Hawkins, Erik does not do reviews, dhollowa
Visibility:
Public.

Description

Move pe_image and registry from base to base/win and use the namespace. It removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62888

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+428 lines, -2158 lines)
M app/win/iat_patch_function.h View 1 chunk +0 lines, -1 line 0 comments
M app/win/iat_patch_function.cc View 3 chunks +3 lines, -2 lines 0 comments
M base/base.gyp View 4 chunks +2 lines, -7 lines 0 comments
M base/base.gypi View 3 chunks +4 lines, -4 lines 0 comments
M base/file_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments
D base/pe_image.h View 1 chunk +0 lines, -258 lines 0 comments
D base/pe_image.cc View 1 chunk +0 lines, -564 lines 0 comments
D base/pe_image_unittest.cc View 1 chunk +0 lines, -213 lines 0 comments
M base/registry.h View 1 chunk +20 lines, -146 lines 0 comments
D base/registry.cc View 1 chunk +0 lines, -381 lines 0 comments
D base/registry_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments
A + base/win/pe_image.h View 3 chunks +10 lines, -4 lines 0 comments
A + base/win/pe_image.cc View 2 chunks +8 lines, -2 lines 0 comments
A + base/win/pe_image_unittest.cc View 2 chunks +7 lines, -1 line 0 comments
A + base/win/registry.h View 3 chunks +9 lines, -3 lines 0 comments
A + base/win/registry.cc View 3 chunks +7 lines, -1 line 0 comments
A + base/win/registry_unittest.cc View 2 chunks +7 lines, -1 line 0 comments
M base/win_util.cc View 3 chunks +4 lines, -4 lines 0 comments
D base/windows_message_list.h View 1 chunk +0 lines, -249 lines 0 comments
M chrome/app/breakpad_win.cc View 2 chunks +5 lines, -3 lines 0 comments
M chrome/browser/autofill/autofill_ie_toolbar_import_win.cc View 3 chunks +7 lines, -3 lines 0 comments
M chrome/browser/autofill/autofill_ie_toolbar_import_win_unittest.cc View 1 chunk +3 lines, -1 line 0 comments
M chrome/browser/background_mode_manager.cc View 2 chunks +5 lines, -5 lines 0 comments
M chrome/browser/download/download_util.cc View 2 chunks +2 lines, -3 lines 0 comments
M chrome/browser/extensions/extension_rlz_apitest.cc View 2 chunks +4 lines, -3 lines 0 comments
M chrome/browser/extensions/external_registry_extension_provider_win.cc View 3 chunks +6 lines, -6 lines 0 comments
M chrome/browser/first_run/first_run_win.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome/browser/history/history_publisher_win.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome/browser/importer/firefox_importer_utils_win.cc View 3 chunks +7 lines, -5 lines 0 comments
M chrome/browser/importer/ie_importer.cc View 3 chunks +5 lines, -2 lines 0 comments
M chrome/browser/platform_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome/browser/plugin_service.h View 2 chunks +3 lines, -3 lines 0 comments
M chrome/browser/policy/configuration_policy_provider_win.h View 2 chunks +4 lines, -2 lines 0 comments
M chrome/browser/policy/configuration_policy_provider_win.cc View 3 chunks +29 lines, -23 lines 0 comments
M chrome/browser/policy/configuration_policy_provider_win_unittest.cc View 2 chunks +3 lines, -1 line 0 comments
M chrome/browser/rlz/rlz_unittest.cc View 1 chunk +4 lines, -1 line 0 comments
M chrome/browser/shell_integration_win.cc View 3 chunks +5 lines, -4 lines 0 comments
M chrome/browser/views/external_protocol_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome/browser/views/shell_dialogs_win.cc View 3 chunks +4 lines, -4 lines 0 comments
M chrome/common/chrome_plugin_lib.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome/installer/setup/install.cc View 3 chunks +6 lines, -5 lines 0 comments
M chrome/installer/setup/uninstall.cc View 2 chunks +3 lines, -1 line 0 comments
M chrome/installer/util/browser_distribution.h View 2 chunks +5 lines, -1 line 0 comments
M chrome/installer/util/browser_distribution.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome/installer/util/compat_checks.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome/installer/util/create_reg_key_work_item.cc View 1 chunk +3 lines, -1 line 0 comments
M chrome/installer/util/create_reg_key_work_item_unittest.cc View 1 chunk +23 lines, -18 lines 0 comments
M chrome/installer/util/delete_after_reboot_helper.cc View 3 chunks +5 lines, -5 lines 0 comments
M chrome/installer/util/delete_after_reboot_helper_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments
M chrome/installer/util/delete_reg_value_work_item.cc View 1 chunk +3 lines, -1 line 0 comments
M chrome/installer/util/delete_reg_value_work_item_unittest.cc View 1 chunk +24 lines, -19 lines 0 comments
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +1 line, -1 line 0 comments
M chrome/installer/util/google_chrome_distribution.cc View 3 chunks +5 lines, -3 lines 0 comments
M chrome/installer/util/google_update_settings.cc View 1 chunk +3 lines, -1 line 0 comments
M chrome/installer/util/google_update_settings_unittest.cc View 1 chunk +3 lines, -1 line 0 comments
M chrome/installer/util/install_util.h View 2 chunks +7 lines, -1 line 0 comments
M chrome/installer/util/install_util.cc View 2 chunks +3 lines, -1 line 0 comments
M chrome/installer/util/set_reg_value_work_item.cc View 3 chunks +3 lines, -3 lines 0 comments
M chrome/installer/util/set_reg_value_work_item_unittest.cc View 1 chunk +26 lines, -22 lines 0 comments
M chrome/installer/util/shell_util.cc View 4 chunks +5 lines, -2 lines 0 comments
M chrome/installer/util/work_item_list_unittest.cc View 1 chunk +34 lines, -30 lines 0 comments
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 1 chunk +3 lines, -1 line 0 comments
M chrome/test/plugin/plugin_test.cpp View 2 chunks +2 lines, -2 lines 0 comments
M chrome_frame/chrome_tab.cc View 2 chunks +3 lines, -1 line 0 comments
M chrome_frame/crash_reporting/crash_metrics.cc View 3 chunks +3 lines, -3 lines 0 comments
M chrome_frame/policy_settings.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome_frame/test/chrome_frame_test_utils.cc View 3 chunks +4 lines, -3 lines 0 comments
M chrome_frame/test/perf/chrome_frame_perftest.cc View 4 chunks +4 lines, -3 lines 0 comments
M chrome_frame/test/policy_settings_unittest.cc View 1 chunk +3 lines, -1 line 0 comments
M chrome_frame/test/util_unittests.cc View 1 chunk +3 lines, -1 line 0 comments
M chrome_frame/utils.cc View 4 chunks +5 lines, -3 lines 0 comments
M net/base/platform_mime_util_win.cc View 3 chunks +5 lines, -5 lines 0 comments
M net/base/ssl_config_service_win.cc View 1 chunk +2 lines, -1 line 0 comments
M net/proxy/proxy_config_service_win.cc View 2 chunks +2 lines, -2 lines 0 comments
M sandbox/src/eat_resolver.cc View 2 chunks +2 lines, -2 lines 0 comments
M sandbox/src/interception.cc View 2 chunks +2 lines, -2 lines 0 comments
M sandbox/src/policy_broker.cc View 2 chunks +2 lines, -2 lines 0 comments
M sandbox/src/resolver.cc View 2 chunks +2 lines, -2 lines 0 comments
M sandbox/src/sandbox_nt_util.cc View 2 chunks +2 lines, -2 lines 0 comments
M sandbox/src/service_resolver.cc View 2 chunks +2 lines, -2 lines 0 comments
M sandbox/src/sidestep_resolver.cc View 2 chunks +2 lines, -2 lines 0 comments
M sandbox/src/target_process.cc View 2 chunks +2 lines, -2 lines 0 comments
M webkit/glue/plugins/plugin_list_win.cc View 5 chunks +9 lines, -7 lines 0 comments
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 2 chunks +2 lines, -2 lines 0 comments

Powered by Google App Engine