chrome_frame/crash_reporting/crash_metrics.cc - Issue 3836005: Move pe_image and registry from base to base/win and use the namespace. It re...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/crash_reporting/crash_metrics.cc

Issue 3836005: Move pe_image and registry from base to base/win and use the namespace. It re... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/crash_reporting/crash_metrics.cc

===================================================================

--- chrome_frame/crash_reporting/crash_metrics.cc (revision 62848)

+++ chrome_frame/crash_reporting/crash_metrics.cc (working copy)

@@ -5,7 +5,7 @@

#include "chrome_frame/crash_reporting/crash_metrics.h"

#include "base/metrics/histogram.h"

-#include "base/registry.h"

+#include "base/win/registry.h"

#include "chrome_frame/utils.h"

static const wchar_t kChromeFrameMetricsKey[] =

@@ -28,7 +28,7 @@

bool CrashMetricsReporter::SetMetric(Metric metric, int value) {

DCHECK(metric >= NAVIGATION_COUNT && metric <= LAST_METRIC);

- RegKey metric_key;

+ base::win::RegKey metric_key;

if (metric_key.Create(HKEY_CURRENT_USER, kChromeFrameMetricsKey,

KEY_SET_VALUE)) {

if (metric_key.WriteValue(g_metric_names[metric], value)) {

@@ -47,7 +47,7 @@

DCHECK(metric >= NAVIGATION_COUNT && metric <= LAST_METRIC);

int ret = 0;

- RegKey metric_key;

+ base::win::RegKey metric_key;

if (metric_key.Open(HKEY_CURRENT_USER, kChromeFrameMetricsKey,

KEY_QUERY_VALUE)) {

int value = 0;

« no previous file with comments | « chrome_frame/chrome_tab.cc ('k') | chrome_frame/policy_settings.cc » ('j') | no next file with comments »