Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 3836001: Get rid of requested size in RetryAfterGC. (Closed)

Created:
10 years, 2 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Get rid of requested size in RetryAfterGC. This was only used by Heap::CollectGarbage to check if after GC available space is bigger than was requested, but nobody checked the value returned by Heap::CollectGarbage, so requested size was efficiently unused. However, it may trigger spurious out of memory exceptions if requested size is big enough. BUG=http://code.google.com/p/chromium/issues/detail?id=54580 Committed: http://code.google.com/p/v8/source/detail?r=5642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -157 lines) Patch
M src/heap.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/heap.cc View 7 chunks +14 lines, -33 lines 0 comments Download
M src/heap-inl.h View 3 chunks +7 lines, -4 lines 0 comments Download
M src/objects.h View 3 chunks +3 lines, -12 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/objects-inl.h View 2 chunks +8 lines, -23 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/spaces-inl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 9 chunks +20 lines, -20 lines 0 comments Download
M test/cctest/test-debug.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-decls.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 9 chunks +12 lines, -16 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 11 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Mads, Slava, may you have a look?
10 years, 2 months ago (2010-10-15 18:25:27 UTC) #1
Mads Ager (chromium)
10 years, 2 months ago (2010-10-18 05:37:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698