Issue 3822007: Move BaseDropTarget and BaseDragSource from base to app/win. Remove the "Base...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3822007: Move BaseDropTarget and BaseDragSource from base to app/win. Remove the "Base... (Closed)

Created:
10 years, 2 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move BaseDropTarget and BaseDragSource from base to app/win. Remove the "Base" class name prefix and put in the app::win namespace. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62900

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -579 lines)			Patch
M	app/app_base.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	app/win/drag_source.h	View	3 chunks	+21 lines, -20 lines	0 comments	Download
A +	app/win/drag_source.cc	View	3 chunks	+15 lines, -19 lines	0 comments	Download
A +	app/win/drop_target.h	View	2 chunks	+16 lines, -9 lines	0 comments	Download
A +	app/win/drop_target.cc	View	9 chunks	+34 lines, -30 lines	0 comments	Download
M	base/base.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	base/base_drag_source.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	base/base_drag_source.cc	View	1 chunk	+0 lines, -61 lines	0 comments	Download
D	base/base_drop_target.h	View	1 chunk	+0 lines, -129 lines	0 comments	Download
D	base/base_drop_target.cc	View	1 chunk	+0 lines, -170 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drag_source_win.h	View	4 chunks	+9 lines, -14 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drag_source_win.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_drop_target_win.h	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drop_target_win.cc	View	3 chunks	+5 lines, -8 lines	0 comments	Download
M	views/widget/drop_target_win.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	views/widget/drop_target_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/widget/root_view_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/drag_delegate.h	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	webkit/tools/test_shell/drop_delegate.h	View	1 chunk	+21 lines, -24 lines	0 comments	Download
M	webkit/tools/test_shell/drop_delegate.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ok

Expand Messages | Collapse Messages