Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 3817004: Rename about:labs to about:flags, step 1/3 (Closed)

Created:
10 years, 2 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Nico, arv (Not doing code reviews), ben+cc_chromium.org
Visibility:
Public.

Description

Rename about:labs to about:flags, step 1/3 This changes the url and the text on about:flags to a bit more scary. The text is taken from https://docs.google.com/a/google.com/document/d/1VRZjR3GGX2FJFsAe8AKMAYRNPMp-sH2cefU0KvaQo0M/edit?hl=en# BUG=59139, 53399 TEST=about:labs doesn't do anything any more. about:flags does. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62624

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -97 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +44 lines, -41 lines 6 comments Download
M chrome/browser/browser_about_handler.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/labs_ui.cc View 2 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/labs.cc View 6 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/resources/labs.html View 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/common/url_constants.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/url_constants.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
steps 2 and 3 will be renaming and cleaning up the cc files and the ...
10 years, 2 months ago (2010-10-14 18:25:46 UTC) #1
viettrungluu
LGTM. The critical question is whether we'll end up on a horse at the end. ...
10 years, 2 months ago (2010-10-14 19:39:39 UTC) #2
Nico
10 years, 2 months ago (2010-10-14 19:44:53 UTC) #3
no free ponies/horses, as usual

http://codereview.chromium.org/3817004/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/3817004/diff/1/2#newcode3991
chrome/app/generated_resources.grd:3991: <!-- about:flags -->
On 2010/10/14 19:39:39, viettrungluu wrote:
> "about:flags" or "chrome://flags"?

Neither.

http://codereview.chromium.org/3817004/diff/1/2#newcode3992
chrome/app/generated_resources.grd:3992: <message name="IDS_FLAGS_TITLE"
desc="Title for the chrome://flags page.">
On 2010/10/14 19:39:39, viettrungluu wrote:
> "chrome://flags" or "about:flags"?

Yes

Powered by Google App Engine
This is Rietveld 408576698