chrome/browser/browser_about_handler.cc - Issue 3817004: Rename about:labs to about:flags, step 1/3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 3817004: Rename about:labs to about:flags, step 1/3 (Closed)

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_about_handler.cc

diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc

index 9a759835a438c9c5fe280e0fee26a69cbadb0bcf..be8317a2a56bdc135d00858815032f7ba002c934 100644

--- a/chrome/browser/browser_about_handler.cc

+++ b/chrome/browser/browser_about_handler.cc

@@ -101,9 +101,9 @@ const char kBlobInternalsPath[] = "blob-internals";

const char kCreditsPath[] = "credits";

const char kCachePath[] = "view-http-cache";

const char kDnsPath[] = "dns";

+const char kFlagsPath[] = "flags";

const char kGpuPath[] = "gpu";

const char kHistogramsPath[] = "histograms";

-const char kLabsPath[] = "labs";

const char kMemoryRedirectPath[] = "memory-redirect";

const char kMemoryPath[] = "memory";

const char kStatsPath[] = "stats";

@@ -134,9 +134,9 @@ const char *kAllAboutPaths[] = {

kCachePath,

kCreditsPath,

kDnsPath,

+ kFlagsPath,

kGpuPath,

kHistogramsPath,

- kLabsPath,

kMemoryPath,

kNetInternalsPath,

kPluginsPath,

@@ -259,12 +259,12 @@ std::string AboutAbout() {

html.append("<html><head><title>About Pages</title></head><body>\n");

html.append("<h2>List of About pages</h2><ul>\n");

for (size_t i = 0; i < arraysize(kAllAboutPaths); i++) {

- if (kAllAboutPaths[i] == kLabsPath && !about_labs::IsEnabled())

+ if (kAllAboutPaths[i] == kFlagsPath && !about_labs::IsEnabled())

continue;

if (kAllAboutPaths[i] == kAppCacheInternalsPath ||

kAllAboutPaths[i] == kBlobInternalsPath ||

kAllAboutPaths[i] == kCachePath ||

- kAllAboutPaths[i] == kLabsPath ||

+ kAllAboutPaths[i] == kFlagsPath ||

kAllAboutPaths[i] == kNetInternalsPath ||

kAllAboutPaths[i] == kPluginsPath) {

html.append("<li><a href='chrome://");

@@ -1180,9 +1180,9 @@ bool WillHandleBrowserAboutURL(GURL* url, Profile* profile) {

if (about_labs::IsEnabled()) {

// Rewrite about:labs and about:vaporware to chrome://labs/.

- if (LowerCaseEqualsASCII(url->spec(), chrome::kAboutLabsURL) ||

+ if (LowerCaseEqualsASCII(url->spec(), chrome::kAboutFlagsURL) ||

LowerCaseEqualsASCII(url->spec(), chrome::kAboutVaporwareURL)) {

- *url = GURL(chrome::kChromeUILabsURL);

+ *url = GURL(chrome::kChromeUIFlagsURL);

return true;

}

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/dom_ui/dom_ui_factory.cc » ('j') | no next file with comments »