Issue 3805: autorelease message pumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3805: autorelease message pumps (Closed)

Created:
12 years, 2 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Provide autorelease pool management on the Mac in all types of message pumps. Fix a few unit tests to use autorelease pools as needed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2603

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -12 lines)			Patch
M	base/base.xcodeproj/project.pbxproj	View	1	4 chunks	+6 lines, -0 lines	0 comments	Download
M	base/build/base.vcproj	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/message_pump_default.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	base/message_pump_libevent.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	base/message_pump_mac.mm	View		4 chunks	+10 lines, -3 lines	0 comments	Download
M	base/platform_test_mac.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	base/scoped_nsautorelease_pool.h	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A	base/scoped_nsautorelease_pool.mm	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	base/sys_info_unittest.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM i dig it.