Issue 3800006: Fix event tracing for windows test flakyness....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3800006: Fix event tracing for windows test flakyness.... (Closed)

Created:
10 years, 2 months ago by Sigurður Ásgeirsson

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix event tracing for windows test flakyness. Assert on non-null properties to the static members of the trace controller. Fix usage of same. Add a PostEventsDisabled method to trace producer to which allows for a non-racy enable/disable test. BUG=52388 BUG=59328 TEST=Unittests in the change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62766

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -13 lines)			Patch
M	base/event_trace_consumer_win_unittest.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	base/event_trace_controller_win.cc	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	base/event_trace_controller_win_unittest.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	base/event_trace_provider_win.h	View	1 chunk	+16 lines, -4 lines	0 comments	Download
M	base/event_trace_provider_win.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/trace_event_win_unittest.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages