Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3476)

Unified Diff: base/event_trace_provider_win.h

Issue 3800006: Fix event tracing for windows test flakyness.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/event_trace_controller_win_unittest.cc ('k') | base/event_trace_provider_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/event_trace_provider_win.h
===================================================================
--- base/event_trace_provider_win.h (revision 62730)
+++ base/event_trace_provider_win.h (working copy)
@@ -126,13 +126,25 @@
ULONG Log(EVENT_TRACE_HEADER* event);
protected:
- // These are called after events have been enabled or disabled.
- // Override them if you want to do processing at the start or
- // end of collection.
- // Note: These may be called ETW's thread and they may be racy.
+ // Called after events have been enabled, override in subclasses
+ // to set up state or log at the start of a session.
+ // Note: This function may be called ETW's thread and may be racy,
+ // bring your own locking if needed.
virtual void OnEventsEnabled() {}
+
+ // Called just before events are disabled, override in subclasses
+ // to tear down state or log at the end of a session.
+ // Note: This function may be called ETW's thread and may be racy,
+ // bring your own locking if needed.
virtual void OnEventsDisabled() {}
+ // Called just after events have been disabled, override in subclasses
+ // to tear down state at the end of a session. At this point it's
+ // to late to log anything to the session.
+ // Note: This function may be called ETW's thread and may be racy,
+ // bring your own locking if needed.
+ virtual void PostEventsDisabled() {}
+
private:
ULONG EnableEvents(PVOID buffer);
ULONG DisableEvents();
« no previous file with comments | « base/event_trace_controller_win_unittest.cc ('k') | base/event_trace_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698