Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 3799003: vboot_reference: refine ebuild and add new dev tools (Closed)

Created:
10 years, 2 months ago by Hung-Te
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush, Bill Richardson, gauravsh, vb
Visibility:
Public.

Description

vboot_reference: refine ebuild and add new dev tools New tools are added into vboot_reference to help development. (ref: http://codereview.chromium.org/3822002 http://codereview.chromium.org/3772013 ) Since now host and all targets need to access to devkeys, prompt the /usr/share/vboot/devkeys to be installed by default. After this change, you can simply change firmware to devkeys by command: sudo /usr/share/vboot/bin/make_dev_firmware.sh and change SSD to devkeys by: sudo /usr/share/vboot/bin/make_dev_ssd.sh or even to disable rootfs verification: sudo /usr/share/vboot/bin/make_dev_ssd.sh --remove_rootfs_verification This CL also re-tab and refined the vboot_reference ebuild file. BUG=chrome-os-partner:1276 TEST=emerge-x86-generic vboot_reference; the result has: /usr/share/vboot/devkeys/ # having dev keys and firmware_bmpfv.bin /usr/share/vboot/bin/ # make_dev*.sh, and common/resign_firmwarefd Change-Id: Ia903ea4112206ca24dce6617fca47ffdb4e68b23 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9a8e93b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -21 lines) Patch
M chromeos-base/vboot_reference/vboot_reference-9999.ebuild View 3 chunks +45 lines, -21 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Hung-Te
10 years, 2 months ago (2010-10-15 16:44:57 UTC) #1
Hung-Te
anush: please help to review if this change is OK rspangler: FYI
10 years, 2 months ago (2010-10-15 16:46:14 UTC) #2
anush
LGTM with a nit http://codereview.chromium.org/3799003/diff/1/2 File chromeos-base/vboot_reference/vboot_reference-9999.ebuild (right): http://codereview.chromium.org/3799003/diff/1/2#newcode103 chromeos-base/vboot_reference/vboot_reference-9999.ebuild:103: insinto "${dst_dir}" Don't you want ...
10 years, 2 months ago (2010-10-15 17:15:34 UTC) #3
Hung-Te
http://codereview.chromium.org/3799003/diff/1/2 File chromeos-base/vboot_reference/vboot_reference-9999.ebuild (right): http://codereview.chromium.org/3799003/diff/1/2#newcode103 chromeos-base/vboot_reference/vboot_reference-9999.ebuild:103: insinto "${dst_dir}" It is there because "required by uboot ...
10 years, 2 months ago (2010-10-15 17:35:43 UTC) #4
Randall
LGTM (assuming you've addressed Anush's concerns)
10 years, 2 months ago (2010-10-15 17:36:31 UTC) #5
anush
10 years, 2 months ago (2010-10-15 17:58:29 UTC) #6
LGTM

On Fri, Oct 15, 2010 at 10:35 AM, <hungte@chromium.org> wrote:

>
> http://codereview.chromium.org/3799003/diff/1/2
> File chromeos-base/vboot_reference/vboot_reference-9999.ebuild (right):
>
> http://codereview.chromium.org/3799003/diff/1/2#newcode103
> chromeos-base/vboot_reference/vboot_reference-9999.ebuild:103: insinto
> "${dst_dir}"
> It is there because "required by uboot for cross compile + headers"
> (http://codereview.chromium.org/3607006), so I think we should not
> change it.
>
>
> http://codereview.chromium.org/3799003/show
>

Powered by Google App Engine
This is Rietveld 408576698