Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 3607006: Changing ebuilds for porting vboot_reference to u-boot (Closed)

Created:
10 years, 2 months ago by Che-Liang Chiou
Modified:
9 years ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush
Visibility:
Public.

Description

This CL is a first step toward porting vboot_reference to u-boot. It installs necessary headers and cross-compiled static library of vboot_reference to /build/${BOARD}/, and adds a compile-time dependency from u-boot to vboot_reference. Makefile of u-boot takes a new parameter VBOOT="${ROOT}/usr" pointing to a verify boot implementation. See: http://codereview.chromium.org/3515011 BUG=none TEST=Run "emerge-${BOARD} u-boot" successfully Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a237659

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add install sysincludes.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chromeos-base/vboot_reference/vboot_reference-9999.ebuild View 1 1 chunk +9 lines, -0 lines 0 comments Download
M sys-boot/u-boot/u-boot-9999.ebuild View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Che-Liang Chiou
10 years, 2 months ago (2010-10-05 07:01:51 UTC) #1
Hung-Te
When assigning multiple reviewers, please follow http://dev.chromium.org/developers/committers-responsibility
10 years, 2 months ago (2010-10-05 07:44:42 UTC) #2
clchiou
robotboy: u-boot Randall: vboot_reference Hung-Te: FYI On 2010/10/05 07:44:42, Hung-Te wrote: > When assigning multiple ...
10 years, 2 months ago (2010-10-05 09:02:48 UTC) #3
Hung-Te
ACK
10 years, 2 months ago (2010-10-05 10:00:49 UTC) #4
Randall Spangler
http://codereview.chromium.org/3607006/diff/1/2 File chromeos-base/vboot_reference/vboot_reference-9999.ebuild (right): http://codereview.chromium.org/3607006/diff/1/2#newcode80 chromeos-base/vboot_reference/vboot_reference-9999.ebuild:80: # Note: sysincludes.h is not installed because bootloader or ...
10 years, 2 months ago (2010-10-05 18:18:39 UTC) #5
Che-Liang Chiou
Hi Randall, I've added sysincludes.h. Please take a look when you have time. http://codereview.chromium.org/3607006/diff/1/2 File ...
10 years, 2 months ago (2010-10-06 01:58:25 UTC) #6
Randall Spangler
LGTM, thanks
10 years, 2 months ago (2010-10-06 16:30:51 UTC) #7
robotboy
LGTM, thank you.
10 years, 2 months ago (2010-10-06 17:05:57 UTC) #8
robotboy
10 years, 2 months ago (2010-10-06 17:32:37 UTC) #9
I'm making the same change to the new chromeos-u-boot and chromeos-u-boot-next
ebuilds and will send out a review request shortly.  I'm also going to be
removing our sys-boot/u-boot ebuilds shortly.  Just a FYI.

Thanks,
    Anton

Powered by Google App Engine
This is Rietveld 408576698