Fix some problems with the ENTER_PASSPHRASE state in sync setup....

Fix some problems with the ENTER_PASSPHRASE state in sync setup.

BUG=48706
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62935

[tim (not reviewing), 2010-10-15 05:20:29]

This LGTM except for a couple nits, and that a) BUG=none will cause you some
grief from laforge's merge police script, and b) it'd be nice to add some
coverage to SyncSetupWizardTest for the added ENTER_PASSPHRASE advance logic.

http://codereview.chromium.org/3792007/diff/1/2
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/3792007/diff/1/2#newcode676
chrome/browser/sync/profile_sync_service.cc:676: void
ProfileSyncService::ShowChooseDataTypes(gfx::NativeWindow parent_window) {
Can you add a todo to change this (or actually change it) to ShowConfigure, or
something like that?

http://codereview.chromium.org/3792007/diff/1/5
File chrome/browser/sync/resources/setting_up.html (right):

http://codereview.chromium.org/3792007/diff/1/5#newcode71
chrome/browser/sync/resources/setting_up.html:71: <div id="setting_up">
ah! was this causing the alignment to be off by any chance?

http://codereview.chromium.org/3792007/diff/1/8
File chrome/browser/sync/sync_ui_util.cc (right):

http://codereview.chromium.org/3792007/diff/1/8#newcode30
chrome/browser/sync/sync_ui_util.cc:30: if (auth_error.state() ==
AuthError::INVALID_GAIA_CREDENTIALS ||
I guess we could / should have a string here for passphrases, but seems like we
have to punt on that for m8, since we're post string freeze.